gateway-api: appProtocol support (GEP-1911) #31310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
d40683e to
d1de40a
Compare
fe729bf to
585f67e
Compare
|
/test |
|
/ci-gateway-api |
|
Thanks for the ping, I have added myself as reviewer. |
|
/ci-gateway-api |
|
From a quick look, the changes are looking good to me. Will take a closer look later. |
00ee5cd to
3b28de2
Compare
sayboras
reviewed
Apr 15, 2024
|
/test |
|
@sayboras |
3b28de2 to
e9bffc6
Compare
squeed
approved these changes
Apr 16, 2024
|
/test |
e9bffc6 to
8135fee
Compare
|
/test |
|
Seems like we just need to wait for ack from other codeowner, so you don't need to rebase with main branch (just to avoid re-run the tests). |
|
@sayboras I occasionally rebase to make sure there are no conflicts, will wait for the ack from the codeowner. |
Understood and thanks, I normally just rely on github UI to flag if there is any conflict with main branch. |
This feature is hidden behind `enable-gateway-api-app-protocol` flag on the operator gwapi cell. Cilium's internal Backend structure is changed to account for appProtocol which is populated from the service spec definitions. Initial implementation sets envoy cluster `http_protocol_options` to use HTTP1.1 and switches to HTTP2 if backendRef service port specified appProtocol with "kubernetes.io/h2c". Fixes: cilium#30452 Signed-off-by: Rauan Mayemir <rauan@mayemir.io>
`enable-gateway-api-app-protocol` is false by default, setting it explicitly will turn appProtocol support on. This will effectively change envoy agent config to use HTTP1.1 for upstreams by default which could potentially break existing users if they are sending ingress request as HTTP2 and also expecting their backends to reply in HTTP2/H2C. They will need to add appProtocol option on the service port to unbreak their workloads. Signed-off-by: Rauan Mayemir <rauan@mayemir.io>
protocol mutator function reset HttpProtocolOptions, leaving only UpstreamProtocolOptions and thus negating WithIdleTimeout mutator changes. Signed-off-by: Rauan Mayemir <rauan@mayemir.io>
This adds gwapi translator test coverage for H2C backend protocol selection when appProtocol enabled or disabled. Signed-off-by: Rauan Mayemir <rauan@mayemir.io>
8135fee to
0c1a4ea
Compare
rauanmayemir
commented
Apr 28, 2024
youngnick
approved these changes
Apr 29, 2024
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.