8000 images/builder: get rid of annoying git ownership warnings by ti-mo · Pull Request #31538 · cilium/cilium · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

images/builder: get rid of annoying git ownership warnings #31538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

ti-mo
Copy link
Contributor
@ti-mo ti-mo commented Mar 21, 2024

Begone, cumbersome git warnings caused by including Makefile.defs:

fatal: detected dubious ownership in repository at '/src'
To add an exception for this directory, call:

	git config --global --add safe.directory /src

cilium-builder will be run as root in various contexts, and git repos will be mounted under random paths, so we can't reasonably target them. Just stop the warnings, they're useless in this context.

Begone, cumbersome git warnings caused by including Makefile.defs:

```
fatal: detected dubious ownership in repository at '/src'
To add an exception for this directory, call:

	git config --global --add safe.directory /src
```

cilium-builder will be run as root in various contexts, and git repos will be
mounted under random paths, so we can't reasonably target them. Just stop the
warnings, they're useless in this context.

Signed-off-by: Timo Beckers <timo@isovalent.com>
@ti-mo ti-mo requested a review from a team as a code owner March 21, 2024 09:46
@ti-mo ti-mo requested a review from glibsm March 21, 2024 09:46
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 21, 2024
@ti-mo ti-mo temporarily deployed to release-base-images March 21, 2024 09:46 — with GitHub Actions Inactive
@ti-mo ti-mo added the release-note/misc This PR makes changes that have no direct user impact. label Mar 21, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 21, 2024
Signed-off-by: Cilium Imagebot <noreply@cilium.io>
@ti-mo ti-mo requested review from a team as code owners March 21, 2024 09:58
@ti-mo ti-mo requested review from christarazi and bimmlerd March 21, 2024 09:58
@auto-committer auto-committer bot temporarily deployed to release-base-images March 21, 2024 09:58 Inactive
@ti-mo
Copy link
Contributor Author
ti-mo commented Mar 21, 2024

/test

@ti-mo ti-mo enabled auto-merge March 21, 2024 13:13
@ti-mo ti-mo added this pull request to the merge queue Mar 22, 2024
Merged via the queue into main with commit 9d43404 Mar 22, 2024
@ti-mo ti-mo deleted the tb/builder-git-warnings branch March 22, 2024 10:36
@aanm aanm added needs-backport/1.14 needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels Oct 7, 2024
@giorio94 giorio94 mentioned this pull request Oct 7, 2024
9 tasks
@giorio94 giorio94 added backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. and removed needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels Oct 7, 2024
@giorio94 giorio94 mentioned this pull request Oct 7, 2024
5 tasks
@github-actions github-actions bot added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. and removed backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. labels Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants
0