crd: Make CiliumNodeConfig available on v2 API #31721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
481157d to
c59ee93
Compare
christarazi
reviewed
Apr 2, 2024
There was a problem hiding this comment.
Thanks for the PR. I have a few suggestions below.
Additionally, I note that this PR is promoting the CRD for a beta feature according to the docs. By doing this promotion, are we considering that this feature is no longer beta? If so, I haven't seen a discussion about what else needs to be done for this feature to be promoted? I am thinking about this comment. I realize that there isn't an easy criteria or path to follow so it might not be clear how to proceed. I'd suggest a Slack thread to begin the discussion and to follow up with a tracking issue for other work that might come up for promoting a feature. I'm not aware of any items personally but others might.
c59ee93 to
a48177a
Compare
a48177a to
a2d38fe
Compare
a2d38fe to
a50cec4
Compare
|
/test |
1 similar comment
|
/test |
aanm
approved these changes
Apr 24, 2024
viktor-kurchenko
approved these changes
Apr 24, 2024
jibi
approved these changes
Apr 29, 2024
040baa2 to
07fb394
Compare
|
/test |
xmulligan
approved these changes
May 7, 2024
94fa863 to
70a0022
Compare
|
/test |
This commit intens to turn CiliumNodeConfig feature to Limited. The CRD is now available in v2 and v2alpha1 API versions. The depreciation of v2alpha1 should be done in another commit. The yaml definition of `CiliumNodeConfig` is in `v2` directory but hold the two versions. Signed-off-by: Donia Chaiehloudj <donia.cld@isovalent.com>
70a0022 to
16cd482
Compare
|
/test |
christarazi
added a commit
to christarazi/cilium
that referenced
this pull request
Jun 20, 2024
Previously, Cilium would always fetch the v2alpha1 version of the CNC even if the v2 version was already found. Fetching the v2alpha1 triggers the deprecation warning from Kubernetes as it was deprecated in cilium#31721. Those warnings cause CI failures such as: ``` FAIL: Found 26 k8s-app=cilium logs matching list of errors that must be investigated: 2024-06-17T13:38:56.846200595Z time="2024-06-17T13:38:56Z" level=warning msg="cilium.io/v2alpha1 CiliumNodeConfig will be deprecated in cilium v1.16; use cilium.io/v2 CiliumNodeConfig" subsys=klog ``` Fixes: db0d41a ("crd, option: Make CiliumNodeConfig available on v2 API") Signed-off-by: Chris Tarazi <chris@isovalent.com>
christarazi
added a commit
to christarazi/cilium
that referenced
this pull request
Jun 26, 2024
Previously, Cilium would always fetch the v2alpha1 version of the CNC even if the v2 version was already found. Fetching the v2alpha1 triggers the deprecation warning from Kubernetes as it was deprecated in cilium#31721. Those warnings cause CI failures such as: ``` FAIL: Found 26 k8s-app=cilium logs matching list of errors that must be investigated: 2024-06-17T13:38:56.846200595Z time="2024-06-17T13:38:56Z" level=warning msg="cilium.io/v2alpha1 CiliumNodeConfig will be deprecated in cilium v1.16; use cilium.io/v2 CiliumNodeConfig" subsys=klog ``` Fixes: db0d41a ("crd, option: Make CiliumNodeConfig available on v2 API") Signed-off-by: Chris Tarazi <chris@isovalent.com>
christarazi
added a commit
to christarazi/cilium
that referenced
this pull request
Jul 24, 2024
Previously, Cilium would always fe F104 tch the v2alpha1 version of the CNC even if the v2 version was already found. Fetching the v2alpha1 triggers the deprecation warning from Kubernetes as it was deprecated in cilium#31721. Those warnings cause CI failures such as: ``` FAIL: Found 26 k8s-app=cilium logs matching list of errors that must be investigated: 2024-06-17T13:38:56.846200595Z time="2024-06-17T13:38:56Z" level=warning msg="cilium.io/v2alpha1 CiliumNodeConfig will be deprecated in cilium v1.16; use cilium.io/v2 CiliumNodeConfig" subsys=klog ``` Fixes: db0d41a ("crd, option: Make CiliumNodeConfig available on v2 API") Signed-off-by: Chris Tarazi <chris@isovalent.com>
marseel
added a commit
to marseel/cilium
that referenced
this pull request
May 14, 2025
Before, ciliumnodeconfigs were registered twice, causing conflict error on k8s apiserver. Example log: verb="POST" URI="/apis/apiextensions.k8s.io/v1/customresourcedefinitions" resp=409 Based on cilium-operator logs, we can see that we tried to create ciliumnodeconfigs CRD twice: Creating CRD [...] name=ciliumnodeconfigs.cilium.io ... Creating CRD [...] name=ciliumnodeconfigs.cilium.io Fixes: cilium#31721 Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 16, 2025
Before, ciliumnodeconfigs were registered twice, causing conflict error on k8s apiserver. Example log: verb="POST" URI="/apis/apiextensions.k8s.io/v1/customresourcedefinitions" resp=409 Based on cilium-operator logs, we can see that we tried to create ciliumnodeconfigs CRD twice: Creating CRD [...] name=ciliumnodeconfigs.cilium.io ... Creating CRD [...] name=ciliumnodeconfigs.cilium.io Fixes: #31721 Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
CiliumNodeConfig CRDon API v2. In this PR we intend to keep the CRD also on v2alpha1 and it will be removed in a next release.