hubble, policy: shuffle types to reduce imports #32378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gandro
approved these changes
May 6, 2024
Hah. I had to actually force-disable that check in |
|
/test |
michi-covalent
approved these changes
May 6, 2024
christarazi
approved these changes
May 6, 2024
|
I gave up and just fixed the struct literals; we use bot |
lambdanis
approved these changes
May 7, 2024
|
/test |
1 similar comment
|
/test |
The "leaf" type pkg/hubble/api/v1 inadvertently imported pkg/policy, which has a large set of imports. This causes a few problems, most notably the hubble CLI binary to have a huge number of unnecessary imports. This also means a large set of the codebase must build on all architectures, unnecessarily to boot. So, this commit has two changes: 1. Lift the policy Key type in to its own package. Since this is referenced **everywhere**, use a type alias to keep our sanity. 2. Move the hubble EndpointInfo interface out of the API type, since it's not really relevant to the API package. This reduces the number of local imports from 196 to 57. A nice cleanup. Signed-off-by: Casey Callendrello <cdc@isovalent.com>
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "leaf" type
pkg/hubble/api/v1inadvertently importedpkg/policy, which has a large set of imports. This causes a few problems, most notably the hubble CLI binary to have a huge number of unnecessary imports. This also means a large set of the codebase must build on all architectures, unnecessarily to boot.So, this commit has two changes:
Lift the policy Key type in to its own package. Since this is referenced everywhere, use a type alias to keep our sanity.
Move the hubble EndpointInfo interface out of the API type, since it's not really relevant to the API package.
This reduces the number of local imports in the hubble binary from 196 to 57. A nice cleanup.