8000 images/builder: let renovate update protoc and proto plugins by rolinh · Pull Request #32739 · cilium/cilium · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

images/builder: let renovate update protoc and proto plugins #32739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 29, 2024

Conversation

rolinh
Copy link
Member
@rolinh rolinh commented May 27, 2024

See commits for details.

@rolinh rolinh added the release-note/misc This PR makes changes that have no direct user impact. label May 27, 2024
@rolinh rolinh had a problem deploying to release-base-images May 27, 2024 16:03 — with GitHub Actions Error
@auto-committer auto-committer bot temporarily deployed to release-base-images May 27, 2024 16:15 Inactive
@rolinh rolinh force-pushed the pr/rolinh/renovate-protoc branch from f224620 to 3240ee1 Compare May 28, 2024 11:03
@rolinh rolinh temporarily deployed to release-base-images May 28, 2024 11:03 — with GitHub Actions Inactive
rolinh added 3 commits May 28, 2024 13:07
Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
Mitchell Hashimoto has announced that he'll be archiving his Go
repositories in early 2024. Switch to using the "blessed fork" for
protoc-gen-go-json.

Ref: https://gist.github.com/mitchellh/90029601268e59a29e64e55bab1c5bdc

Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
@rolinh rolinh force-pushed the pr/rolinh/renovate-protoc branch from 3240ee1 to 4eac68c Compare May 28, 2024 11:09
@rolinh rolinh had a problem deploying to release-base-images May 28, 2024 11:09 — with GitHub Actions Error
@auto-committer auto-committer bot had a problem deploying to release-base-images May 28, 2024 11:20 Error
Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
@rolinh rolinh force-pushed the pr/rolinh/renovate-protoc branch from bd1578d to 9028395 Compare May 28, 2024 11:39
@rolinh rolinh temporarily deployed to release-base-images May 28, 2024 11:39 — with GitHub Actions Inactive
@rolinh rolinh marked this pull request as ready for review May 28, 2024 12:06
@rolinh rolinh requested review from a team as code owners May 28, 2024 12:06
@rolinh rolinh requested review from nebril, chancez, gandro and aanm May 28, 2024 12:06
@rolinh
Copy link
Member Author
rolinh commented May 29, 2024

/test

@rolinh rolinh enabled auto-merge May 29, 2024 09:15
@rolinh rolinh added this pull request to the merge queue May 29, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 29, 2024
Merged via the queue into main with commit 115104c May 29, 2024
279 of 282 checks passed
@rolinh rolinh deleted the pr/rolinh/renovate-protoc branch May 29, 2024 11:22
@gandro
Copy link
Member
gandro commented May 29, 2024

@rolinh It seems this PR broke the renovate config (renovate re-opened this issue just when this was merged): #23230

@@ -420,8 +420,10 @@
{
"fileMatch": [
"images/cilium/download-hubble\\.sh",
"images/runtime/build-gops.sh",
"images/builder/install-protoc.sh",
"images/builder/install-protoplugins.sh",
"images/hubble-relay/download-grpc-health-probe.sh"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing comma

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, nice catch, will fix it!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@giorio94 giorio94 added the backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. label Jan 28, 2025
@github-actions github-actions bot added backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. labels Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants
0