8000 ci-e2e: Set up node local DNS in conformance-e2e by ysksuzuki · Pull Request #33768 · cilium/cilium · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

ci-e2e: Set up node local DNS in conformance-e2e #33768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 9, 2024
Merged

ci-e2e: Set up node local DNS in conformance-e2e #33768

merged 2 commits into from
Aug 9, 2024

Conversation

ysksuzuki
Copy link
Member
@ysksuzuki ysksuzuki commented Jul 12, 2024 •
edited
Loading

This PR introduces node local DNS with LRP in conformance-e2e following the LRP document, and run local-redirect-policy-with-node-dns test.

https://docs.cilium.io/en/stable/network/kubernetes/local-redirect-policy/#node-local-dns-cache

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 12, 2024
@ysksuzuki
Copy link
Member Author

/test

@ysksuzuki ysksuzuki force-pushed the pr/ysksuzuki/lrp-node-dns branch from e11447f to 9c12ac6 Compare July 12, 2024 15:00
@ysksuzuki
Copy link
Member Author

/test

@ysksuzuki ysksuzuki force-pushed the pr/ysksuzuki/lrp-node-dns branch 2 times, most recently from 86955bc to d4f0b8e Compare July 12, 2024 15:41
@ysksuzuki
Copy link
Member Author

/test

@ysksuzuki ysksuzuki force-pushed the pr/ysksuzuki/lrp-node-dns branch from d4f0b8e to 7aa8606 Compare July 12, 2024 15:58
@ysksuzuki
Copy link
Member Author

/test

@ysksuzuki ysksuzuki force-pushed the pr/ysksuzuki/lrp-node-dns branch from 7aa8606 to a652eff Compare July 13, 2024 13:14
@ysksuzuki
Copy link
Member Author

/test

@ysksuzuki ysksuzuki force-pushed the pr/ysksuzuki/lrp-node-dns branch from a652eff to abd09f6 Compare July 13, 2024 14:32
@ysksuzuki
Copy link
Member Author

/test

@ysksuzuki ysksuzuki force-pushed the pr/ysksuzuki/lrp-node-dns branch from abd09f6 to 8eea67e Compare July 14, 2024 19:04
@ysksuzuki
Copy link
Member Author

/test

@ysksuzuki ysksuzuki mentioned this pull request Jul 15, 2024
Merged
@ysksuzuki ysksuzuki force-pushed the pr/ysksuzuki/lrp-node-dns branch from 8eea67e to c3b8b9e Compare August 8, 2024 09:12
@ysksuzuki
Copy link
Member Author

/test

@ysksuzuki ysksuzuki added release-note/ci This PR makes changes to the CI. area/lrp Impacts Local Redirect Policy. labels Aug 8, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Aug 8, 2024
@ysksuzuki ysksuzuki added the backport/1.16 This PR represents a backport for Cilium 1.16.x of a PR that was merged to main. label Aug 8, 2024
ysksuzuki
ysksuzuki commented Aug 8, 2024
View reviewed changes
@ysksuzuki ysksuzuki added backport/author The backport will be carried out by the author of the PR. needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch and removed backport/1.16 This PR represents a backport for Cilium 1.16.x of a PR that was merged to main. labels Aug 8, 2024
@ysksuzuki
ci-e2e: Set up node local DNS in conformance-e2e
852b492 
This commit introduces node local DNS with LRP following
the LRP document.

https://docs.cilium.io/en/stable/network/kubernetes/local-redirect-policy/#node-local-dns-cache

Signed-off-by: Yusuke Suzuki <yusuke.suzuki@isovalent.com>
@ysksuzuki ysksuzuki force-pushed the pr/ysksuzuki/lrp-node-dns branch from c3b8b9e to ca73e96 Compare August 8, 2024 13:37
@ysksuzuki
Copy link
Member Author

/test

@ysksuzuki
ci-e2e: Set up node local DNS in e2e-upgrade
c482707 
Signed-off-by: Yusuke Suzuki <yusuke.suzuki@isovalent.com>
@ysksuzuki ysksuzuki force-pushed the pr/ysksuzuki/lrp-node-dns branch from ca73e96 to c482707 Compare August 8, 2024 14:00
@ysksuzuki
Copy link
Member Author

/test

@ysksuzuki ysksuzuki marked this pull request as ready for review August 9, 2024 04:27
@ysksuzuki ysksuzuki requested review from a team as code owners August 9, 2024 04:27
@aanm aanm enabled auto-merge August 9, 2024 10:25
learnitall
learnitall suggested changes Aug 9, 2024
View reviewed changes
Copy link
Contributor
@learnitall learnitall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind moving the kustomization.yaml and copying the node-local-dns.yaml and node-local-dns-lrp.yaml manifests into a new directory at .github/actions/node-local-dns? The examples directory has a different review process than CI related files. If someone reviewing a change to the manifests in the examples/kubernetes-local-redirect doesn't know it's being used by a CI workflow, an accident might occur where a change causes the workflow to break.

@ysksuzuki
Copy link
Member Author

@learnitall local-redirect-policy-with-node-dns test checks if the node local DNS with LRP using the manifests in examples/kubernetes-local-redirect is working as expected. (described here) So CI should fail If someone changes the manifests in the examples/kubernetes-local-redirect and break it.

@learnitall
Copy link
Contributor

Ack, ok that makes sense @ysksuzuki. Thank you for clarifying. I brought it up mainly because it feels like a bit of a "code smell" to have stuff for CI in examples, but that's probably a larger repo structure question that can be dug into at a later time.

@aanm aanm added this pull request to the merge queue Aug 9, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Aug 9, 2024
Merged via the queue into main with commit ac0a511 Aug 9, 2024
295 checks passed
@aanm aanm deleted the pr/ysksuzuki/lrp-node-dns branch August 9, 2024 19:44
@ysksuzuki ysksuzuki mentioned this pull request Aug 11, 2024
Closed
@ysksuzuki ysksuzuki mentioned this pull request Sep 28, 2024
Merged
@julianwiedmann julianwiedmann added backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. and removed needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tklauser tklauser tklauser approved these changes

@aanm aanm aanm approved these changes

@learnitall learnitall learnitall approved these changes

Assignees
No one assigned
Labels
area/lrp Impacts Local Redirect Policy. backport/author The backport will be carried out by the author of the PR. backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ysksuzuki @learnitall @tklauser @aanm @julianwiedmann
0