.github: ginkgo: remove duplicate datapath ipv4only test in f09/f21. #34071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e150ea1 sought to split these tests into two, however 'K8sDatapathConfig IPv4Only' was in the list twice and so was left in both test suites. This removes this from f09. Signed-off-by: Tom Hadlaw <tom.hadlaw@isovalent.com>
|
/test |
f09 is still quite a bit heavier than f21 in terms of test time. This is because many of the tests moved to f09 are actually skipped. High scale ipcache is currently the longest running test inside f09 so let move that to f21 as well. Signed-off-by: Tom Hadlaw <tom.hadlaw@isovalent.com>
|
/test |
sayboras
approved these changes
Jul 29, 2024
As a final measure, this moves the 'WireGuard encryption strict mode' type tests to f21. These collectively take around 7 minutes, so this should balance f09/f21 more. Signed-off-by: Tom Hadlaw <tom.hadlaw@isovalent.com>
|
/test |
|
Delayed this as I was confused why certain tests where being skipped, realized that scheduled and PR runs use different kernel versions so have different skipped tests so this should be good to go. |
|
@viktor-kurchenko could you take a look as well if you have some time 😄 |
|
Never mind I guess Tams review was sufficient. |
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e150ea1 sought to split these tests into two, however 'K8sDatapathConfig IPv4Only' was in the list twice and so was left in both test suites.
This removes this from f09.
As well, the second commit moves the "High Scale IPCache" over to f21 as well as most of the previously moved tests where actually skipped.