v1.16: backport "Fix lo and fallback node address selection" #34085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test-backport-1.16 |
[ upstream commit a9e9666 ] This fixes a regression where the non-loopback addresses assigned to the loopback device (lo) were not considered host/node addresses. This broke the practice of assigning VIPs to the loopback device to make Cilium consider them. The problem was due to filtering on "ExcludedDevicePrefixes" that included "lo". This filtering is already done in the devices controller that populates the Table[Device] that this code reads, so this filtering can be dropped. In addition to this the fix whitelists the lo device to make it unnecessary to specify "--devices=lo,..." and thus retaining the same semantics as v1.14. Fixes: #33214 Signed-off-by: Jussi Maki <jussi@isovalent.com>
[ upstream commit 28e9ade ] The fallback is used for e.g. BPF masquerading when the target device has no address, this is "best effort" for ECMP etc. setups). The selection algorithm for the fallback node address wasn't taking into account whether the device was selected or not, which led to the fallback address being taken from non-selected devices. Add selected as the first criteria for checking if a fallback is better. And to avoid unnecessary churn on updating the fallback, always skip lxc* devices. Signed-off-by: Jussi Maki <jussi@isovalent.com>
8c448af to
387de6e
Compare
|
/test-backport-1.16 |
dylandreimerink
approved these changes
Aug 2, 2024
julianwiedmann
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once this PR is merged, a GitHub action will update the labels of these PRs: