[v1.16] docs: Add note for CNP empty slices semantic under v1.16 section #34008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following the change in the semantic of an empty non-nil slice in CNPs, an upgrade note is added to the guide for v1.16. The semantic change targeted v1.16 but this release note was inadvertently appended under the "v1.15 Upgrade Notes" section and thus deleted when preparing the documentation for v1.16. Related: e47e295 ("docs: cleanup upgrade docs on 1.16") Related: 966757d ("docs: add upgrade note for dangling cidrGroupRefs") Fixes: 5f77d50 ("docs: Add upgrade note for CNP empty slices new semantic") Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
|
/test-backport-1.16 |
squeed
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The semantic change for empty non-nil slice in CNPs targeted v1.16, but the related release note was inadvertently appended under the "v1.15 Upgrade Notes" section (see PR #29608). Therefore, that note was deleted when preparing the documentation for v1.16 in #33703
The PR adds back the upgrade note in the v1.16 section where it belongs.
Related: e47e295 ("docs: cleanup upgrade docs on 1.16")
Related: 966757d ("docs: add upgrade note for dangling cidrGroupRefs")
Fixes: 5f77d50 ("docs: Add upgrade note for CNP empty slices new semantic")