CFP-25694: Move cilium/cilium-cli code into cilium/cilium repository #34178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9879e79 to
cc94e7d
Compare
cc94e7d to
45852f4
Compare
45852f4 to
98081fe
Compare
|
/test |
98081fe to
d18d7ba
Compare
d18d7ba to
63a669c
Compare
63a669c to
f43b019
Compare
f43b019 to
251c9d1
Compare
|
/test |
251c9d1 to
459a346
Compare
Build CI image for cilium-cli, and update all the workflows to use the CI image instead of the image built from a release tag. Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
e497a37 to
87e022c
Compare
|
/test |
michi-covalent
added a commit
to cilium/cilium-cli
that referenced
this pull request
Aug 16, 2024
cilium/cilium#34178 got merged. Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
added a commit
to cilium/cilium-cli
that referenced
this pull request
Aug 16, 2024
Most of the Go code will get deleted once cilium/cilium#34178 gets merged. Update CODEOWNERS first to avoid pulling in too many people for review when these files get deleted. Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
added a commit
to cilium/cilium-cli
that referenced
this pull request
Aug 16, 2024
Most of the Go code will get deleted once cilium/cilium#34178 gets merged. Update CODEOWNERS first to avoid pulling in too many people for review when these files get deleted. Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
added a commit
to cilium/cilium-cli
that referenced
this pull request
Aug 16, 2024
cilium/cilium#34178 got merged. Remove the lock workflow and update CONTRIBUTING.md. Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
added a commit
to cilium/cilium-cli
that referenced
this pull request
Aug 20, 2024
cilium/cilium#34178 got merged. Remove the lock workflow and update CONTRIBUTING.md. Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
1 task
michi-covalent
added a commit
to cilium/cilium-cli
that referenced
this pull request
Aug 20, 2024
Most of the Go code has been moved to cilium/cilium repo [^1], and the only direct dependencies are cilium/cilium and google/gops at this point. I don't think it makes much sense to pull in the vendor team for reviewing new versions of cilium and / or gops. I'm imagining the new release process will look something like this: - Renovate picks up a new cilium/cilium pre-release from main branch. Pre-releases happen roughly once a month. - cilium-cli-maintainers team approves and merges the Renovate PR. - cilium-cli-maintainers team cuts a new cilium-cli release. [^1]: cilium/cilium#34178 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
added a commit
to cilium/cilium-cli
that referenced
this pull request
Aug 20, 2024
Most of the Go code has been moved to cilium/cilium repo [^1], and the only direct dependencies are cilium/cilium and google/gops at this point. I don't think it makes much sense to pull in the vendor team for reviewing new versions of cilium and / or gops. I'm imagining the new release process will look something like this: - Renovate picks up a new cilium/cilium pre-release from main branch. Pre-releases happen roughly once a month. - cilium-cli-maintainers team approves and merges the Renovate PR. - cilium-cli-maintainers team cuts a new cilium-cli release. [^1]: cilium/cilium#34178 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
added a commit
to cilium/cilium-cli
that referenced
this pull request
Apr 4, 2025
Cilium CLI code has moved to cilium/cilium repo [^1], and this repo is only used to build and publish releases. Cilium CLI already gets tested against cloud providers in cilium/cilium repo, so remove them from this repo. Let's keep the Kind workflow as a sanity check for now. [^1]: cilium/cilium#34178 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
added a commit
to cilium/cilium-cli
that referenced
this pull request
Apr 8, 2025
Cilium CLI code has moved to cilium/cilium repo [^1], and this repo is only used to build and publish releases. Cilium CLI already gets tested against cloud providers in cilium/cilium repo, so remove them from this repo. Let's keep the Kind workflow as a sanity check for now. [^1]: cilium/cilium#34178 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
added a commit
to cilium/cilium-cli
that referenced
this pull request
Apr 8, 2025
Cilium CLI code has moved to cilium/cilium repo [^1], and this repo is only used to build and publish releases. Cilium CLI already gets tested against cloud providers in cilium/cilium repo, so remove them from this repo. Let's keep the Kind workflow as a sanity check for now. [^1]: cilium/cilium#34178 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
most of commits are from cilium-cli repo. please review these commits:
8b4d060 - cilium-cli: Remove go.mod
4bd9e9b - Fix lint errors
55a6ded - Remove redundant files
bc6d709 - Update CODEOWNERS for cilium-cli/ directory
e497a37 - Build cilium-cli CI Docker image
ignore the following failures:
BPF Checks / Check Patch: it's complaining about commit message format. i'm not going to rewrite commit messages at this point.Build Commits / Check if build works for every commit: too many commits to build before timing out.Ref: cilium/design-cfps#9
Fixes #25694