8000 chore(plugins): replace deprecated CNI function by SkalaNetworks · Pull Request #34561 · cilium/cilium · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore(plugins): replace deprecated CNI function #34561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 7, 2024
Merged

chore(plugins): replace deprecated CNI function #34561

merged 1 commit into from
Sep 7, 2024

Conversation

SkalaNetworks
Copy link
Contributor

This pull request replaces the deprecated skel.PluginMain with its skel.PluginMainFuncs counterpart It adds a new function to the Cmd structure to convert the CNI methods into a standardized structure that can be passed to skel.PluginMain

If the CNI vendored repo is updated, there's a few other deprecated items introduced that could be cleaned aswell.

@SkalaNetworks
chore(plugins): replace deprecated CNI function
f71bab3 
This pull request replaces the deprecated skel.PluginMain with its skel.PluginMainFuncs counterpart
It adds a new function to the Cmd structure to convert the CNI methods into a standardized structure
that can be passed to skel.PluginMain

Signed-off-by: SkalaNetworks <contact@skala.network>
@SkalaNetworks SkalaNetworks requested a review from a team as a code owner August 25, 2024 10:52
@SkalaNetworks SkalaNetworks requested a review from squeed August 25, 2024 10:52
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Aug 25, 2024
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Aug 25, 2024
@squeed squeed added the release-note/misc This PR makes changes that have no direct user impact. label Aug 26, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Aug 26, 2024
@squeed
Copy link
Contributor
squeed commented Aug 26, 2024

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Sep 6, 2024
@sayboras sayboras added this pull request to the merge queue Sep 7, 2024
Merged via the queue into cilium:main with commit e3a101b Sep 7, 2024
74 checks passed
@SkalaNetworks SkalaNetworks deleted the plugin-deprecated-func branch October 15, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squeed squeed squeed approved these changes

Assignees
No one assigned
Labels
kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SkalaNetworks @squeed @sayboras
0