-
Notifications
You must be signed in to change notification settings - Fork 3.3k
gha: Simplify integration test job #34676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build.sh script was mainly for travis, which is removed a while back. Additionally, the `build` and `precheck` targets are already run in other CIs (e.g. docker build, and lint-go), hence we can just run `make integration-tests` directly from GHA. Signed-off-by: Tam Mach <tam.mach@cilium.io>
/ci-integration |
/test |
Commit 623a7ba does not match "(?m)^Signed-off-by:". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
/ci-integration |
Just a note that -progress flag is changed to -follow as per the latest release. Signed-off-by: Tam Mach <tam.mach@cilium.io>
257b087
to
8c835c8
Compare
/test |
aanm
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build.sh script was mainly for travis, which is removed a while back. Additionally, the
build
andprecheck
targets are already run in other CIs (e.g. docker build, and lint-go), hence we can just runmake integration-tests
directly from GHA.The runtime is reducing by half (from ~30m to ~14m).