8000 gha: Simplify integration test job by sayboras · Pull Request #34676 · cilium/cilium · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

gha: Simplify integration test job #34676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Conversation

sayboras
Copy link
Member
@sayboras sayboras commented Sep 4, 2024

The build.sh script was mainly for travis, which is removed a while back. Additionally, the build and precheck targets are already run in other CIs (e.g. docker build, and lint-go), hence we can just run make integration-tests directly from GHA.

The runtime is reducing by half (from ~30m to ~14m).

The build.sh script was mainly for travis, which is removed a while
back. Additionally, the `build` and `precheck` targets are already run
in other CIs (e.g. docker build, and lint-go), hence we can just run
`make integration-tests` directly from GHA.

Signed-off-by: Tam Mach <tam.mach@cilium.io>
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 4, 2024
@sayboras sayboras added the release-note/ci This PR makes changes to the CI. label Sep 4, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 4, 2024
@sayboras
Copy link
Member Author
sayboras commented Sep 4, 2024

/ci-integration

@sayboras sayboras marked this pull request as ready for review September 4, 2024 09:29
@sayboras sayboras requested review from a team as code owners September 4, 2024 09:29
@sayboras sayboras requested review from aanm and nebril September 4, 2024 09:29
@sayboras
Copy link
Member Author
sayboras commented Sep 4, 2024

/test

@sayboras sayboras marked this pull request as draft September 4, 2024 09:56
@maintainer-s-little-helper
Copy link

Commit 623a7ba does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Sep 4, 2024
@sayboras
Copy link
Member Author
sayboras commented Sep 4, 2024

/ci-integration

Just a note that -progress flag is changed to -follow as per the latest
release.

Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras sayboras force-pushed the pr/tammach/simplify-integration-test branch from 257b087 to 8c835c8 Compare September 4, 2024 10:36
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Sep 4, 2024
@sayboras
Copy link
Member Author
sayboras commented Sep 4, 2024

/test

@sayboras sayboras marked this pull request as ready for review September 4, 2024 11:07
@sayboras sayboras requested a review from a team as a code owner September 4, 2024 11:07
@aanm aanm added this pull request to the merge queue Sep 4, 2024
Merged via the queue into main with commit 1985de4 Sep 4, 2024
287 checks passed
@aanm aanm deleted the pr/tammach/simplify-integration-test branch September 4, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0