8000 .github: prevent failure when deleting GitHub Actions cache by aanm · Pull Request #34844 · cilium/cilium · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

.github: prevent failure when deleting GitHub Actions cache #34844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

aanm
Copy link
Member
@aanm aanm commented Sep 12, 2024

Added || true to gh actions-cache delete commands to ensure the workflow continues even if cache deletion fails.

Fixes: 8cdb2dc (".github/workflows: fix ci image cache cleaner")

I don't know why it failed as this is an example provided in the documentation 😕 https://github.com/actions/cache/blob/main/tips-and-workarounds.md#force-deletion-of-caches-overriding-default-cache-eviction-policy

Added `|| true` to `gh actions-cache delete` commands to ensure the workflow
continues even if cache deletion fails.

Fixes: 8cdb2dc (".github/workflows: fix ci image cache cleaner")
Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm added kind/bug/CI This is a bug in the testing code. area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. labels Sep 12, 2024
@aanm aanm requested review from a team as code owners September 12, 2024 09:08
@aanm aanm requested a review from christarazi September 12, 2024 09:08
@aanm
Copy link
Member Author
aanm commented Sep 12, 2024

/test

@aanm aanm enabled auto-merge September 12, 2024 14:03
@aanm aanm added this pull request to the merge queue Sep 12, 2024
Merged via the queue into main with commit d32ff87 Sep 12, 2024
267 checks passed
@aanm aanm deleted the pr/continue-on-error branch September 12, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake kind/bug/CI This is a bug in the testing code. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0