cli: bugfix connectivity perf command #35063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, regular connectivity tests and perf tests are still a bit coupled, but they can't be run concurrently. In case of LRP enabled, we were deploying only perf pods, but validation of deployments was waiting for lrp pod too. As we have to separate functions for deploying deployments and validating deployments, we need to keep them in sync. Now in validation of deployments, return early in case of perf command, just like in a deploy function. Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
|
/test |
christarazi
approved these changes
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, regular connectivity tests and perf tests are still a bit coupled, but they can't be run concurrently.
In the case of LRP enabled, we were deploying only perf pods, but the validation of deployments was waiting for lrp pod too:
As we have to separate functions for deploying deployments and validating deployments, we need to keep them in sync. Now in validation of deployments, return early in case of perf command, just like in a deploy function.