8000 Fix wrongly spelled config option in error message by baurmatt · Pull Request #35390 · cilium/cilium · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix wrongly spelled config option in error message #35390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2024
Merged

Fix wrongly spelled config option in error message #35390

merged 1 commit into from
Oct 22, 2024

Conversation

baurmatt
Copy link
Contributor

Seems like the config option has been renamed in the inital PR while it was reviewed but this instance has been missed.

See #32733

<!-- Enter the release note text here if needed or remove this section! -->

@baurmatt baurmatt requested a review from a team as a code owner October 14, 2024 12:37
@baurmatt baurmatt requested a review from markpash October 14, 2024 12:37
@maintainer-s-little-helper
Copy link

Commit c77f7f6 does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Oct 14, 2024
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Oct 14, 2024
@maintainer-s-little-helper
Copy link

Commit c77f7f6 does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@aanm aanm added release-note/misc This PR makes changes that have no direct user impact. and removed dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. labels Oct 21, 2024

@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 21, 2024
@aanm aanm added the needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch label Oct 21, 2024
@aanm aanm enabled auto-merge October 21, 2024 10:06
@aanm
Copy link
Member
aanm commented Oct 21, 2024

/test

@aanm aanm disabled auto-merge October 21, 2024 15:30
@aanm aanm enabled auto-merge October 21, 2024 15:31
@aanm aanm disabled auto-merge October 22, 2024 07:08
@aanm
Copy link
Member
aanm commented Oct 22, 2024

@baurmatt it needs a rebase as there were flakes fixed in upstream.

@baurmatt
Fix wrongly spelled config option in error message
5782db2 
Seems like the config option has been renamed in the inital PR while it
was reviewed but this instance has been missed.

See cilium#32733

Signed-off-by: Matthias Baur <m.baur@syseleven.de>
@baurmatt
Copy link
Contributor Author

@aanm Done! :)

@aanm
Copy link
Member
aanm commented Oct 22, 2024

/test

@aanm aanm enabled auto-merge October 22, 2024 08:23
@aanm aanm added this pull request to the merge queue Oct 22, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 22, 2024
Merged via the queue into cilium:main with commit b418310 Oct 22, 2024
62 of 63 checks passed
@tklauser tklauser mentioned this pull request Oct 25, 2024
Merged
7 tasks
@tklauser tklauser added the backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. label Oct 25, 2024
@tklauser tklauser removed the needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch label Oct 25, 2024
@github-actions github-actions bot added backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. and removed backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. labels Oct 25, 2024
@cilium-release-bot cilium-release-bot bot mentioned this pull request Nov 13, 2024
Merged
@baurmatt baurmatt deleted the fix-error-messsage branch November 13, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markpash markpash markpash approved these changes

Assignees
No one assigned
Labels
backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@baurmatt @aanm @markpash @tklauser
0