wireguard: attach Ingress program for native routing mode configurations #37108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without the `from-netdev` program at cilium_wg0's Ingress hook, received packets drop into the host network stack and are then delivered via cilium_host / cilium_net. This impacts configurations with BPF Host Routing, as packets are unexpectedly observed by the host stack. It is also different from overlay routing mode (where such packets are subsequently handled by `from-overlay` and delivered to local endpoints using BPF), or a configuration without encryption (where such packets are delivered to local endpoints by `from-netdev` at the native device). Therefore change the condition in NeedBPFHostOnWireGuardDevice() to also consider native routing mode. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
|
/test |
jschwinger233
approved these changes
Jan 21, 2025
14 tasks
1 task
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the
from-netdevprogram at cilium_wg0's Ingress hook, received packets drop into the host network stack and are then delivered via cilium_host / cilium_net.This impacts configurations with BPF Host Routing, as packets are unexpectedly observed by the host stack. It is also different from overlay routing mode (where such packets are subsequently handled by
from-overlayand delivered to local endpoints using BPF), or a configuration without encryption (where such packets are delivered to local endpoints byfrom-netdevat the native device).Therefore change the condition in NeedBPFHostOnWireGuardDevice() to also consider native routing mode.