refactor: move WithUnixSocketListener to a linux specific file #37399
Conversation
|
Commit 691bee0 does not match "(?m)^Signed-off-by:". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
|
Commit 691bee0 does not match "(?m)^Signed-off-by:". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
3a36fac to
8ad16a0
Compare
8ad16a0 to
f9c9013
Compare
f9c9013 to
7aab1b5
Compare
|
Commit 7aab1b5 does not match "(?m)^Signed-off-by:". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
7aab1b5 to
9dee687
Compare
|
@rolinh I have fixed the error reported by the linter. We also want to backport this change to v1.16 and v1.17, Should I make PR for the same or wait till this gets merged? |
Could you squash the commits? We shouldn't create any backport PR until this one is merged. See the doc on backporting. |
|
I marked the PR for backporting to both v1.17 and v1.16 given it's a no-op unless one is building on Windows (which is not a build target for Cilium yet). |
9dee687 to
468c7ba
Compare
|
/test |
Head branch was pushed to by a user without write access
a585e1c to
468c7ba
Compare
43a46ee to
468c7ba
Compare
|
/test |
|
@rolinh can we rerun the failing tests? The log says it was cancelled |
|
One of tests failed again. Also Conformance Kind Envoy Embedded / Installation and Connectivity Test (pull_request) was not retried i guess. |
The Conformance Kind Envoy Embedded test is not marked as required, there's no point retrying it. It seems the same test failed again, might be broken. Could you try to rebase against main? |
Signed-off-by: Ritwik Ranjan <ritwikranjan@microsoft.com>
468c7ba to
742b7c9
Compare
|
/test |
|
Is it good to merge now? anything else required here? |
Overview
This pull request includes changes to refactor the handling of Unix socket listeners in the Hubble server options. The primary changes involve moving the Unix socket listener configuration to a new file specifically for Linux.
Why?
Retina uses hubble as it's dataplane. However we build the retina agent with windows as well, having the unix import is causing failure as we move towards using the newer release of cilium. To address this I have moved the option to use Unix import just for linux builds.
Refactoring Unix socket listener configuration:
pkg/hubble/server/serveroption/option.go: Removed theWithUnixSocketListenerfunction and its associated imports. [1] [2]pkg/hubble/server/serveroption/option_linux.go: Added a new file containing theWithUnixSocketListenerfunction and necessary imports, ensuring the Unix socket listener configuration is specific to Linux.Please ensure your pull request adheres to the following guidelines:
description and a
Fixes: #XXXline if the commit addresses a particularGitHub issue.
Fixes: <commit-id>tag, thenplease add the commit author[s] as reviewer[s] to this issue.