v1.17 Backports 2025-03-12 #38154
Merged
v1.17 Backports 2025-03-12 #38154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ upstream commit 04e4aea ] This commit fixes a subtle bug with Gateway API processing, where a HTTPRoute, GRPCRoute, or TLSRoute with multiple parentRefs set would have status updated for _all_ parentRefs, and would not handle a HTTPRoute with _both_ Gateway and Service (GAMMA) parentRefs correctly. Important changes: - removed the SetAllParentsCondition() function from the Input interface in `operator/pkg/gateway-api/routechecks`, and moved all calls to it to call SetParentCondition per-parentRef instead - added checks to the GAMMA reconciler to ensure that only GAMMA parents are handled (in `operator/pkg/gateway-api`) - added checks to the HTTPRoute, GRPCRoute, and TLSRoute reconcilers to ensure that both GAMMA parentRefs and parentRefs that roll up to other implementations will be skipped processing and have no status updates applied - added tests to cover most of the above (GRPCRoute and TLSRoute reconcilers currently do not have tests, will leave adding them to a follow-up PR) Signed-off-by: Nick Young <nick@isovalent.com> Signed-off-by: Tam Mach <tam.mach@cilium.io>
fa76953 to
efe8601
Compare
youngnick
approved these changes
Mar 12, 2025
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once this PR is merged, a GitHub action will update the labels of these PRs: