cilium-cli: Fix logger busy loop #38199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Break busy loop with 50ms sleeps when no tests are yet running. This happens when cilium-cli waits for test deployments to be ready. Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
2d1755e to
903d25c
Compare
|
/test |
Concurrent logger busy-looped when waiting for the first test to start. While this could be fixed by checking for this case and sleeping a while, it is better to simplify the structure as follows: - have the same goroutine receiving and writing messages, eliminating the need for locking - choose any available test as the current one and stream its messages directly, while buffering messages for all other tests - when the current test is finished, print out the logs of all other finished tests and choose any one of the available tests as the current one Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
903d25c to
f232190
Compare
|
/test |
brlbil
approved these changes
Mar 17, 2025
derailed
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminate concurrent logger busy loop when no tests are yet running. This happens when cilium-cli waits for test deployments to be ready.
1st commit provides the straightforward fix by adding 50ms sleep in the loop where the
printeris waiting for messages.2nd commit refactors
ConcurrentLoggerto eliminate the need fortime.Sleepas well as internal locking as follows: