8000 exp/lb: Add service.cilium.io/type annotation support by brb · Pull Request #38260 · cilium/cilium · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

exp/lb: Add service.cilium.io/type annotation support #38260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2025
Merged

exp/lb: Add service.cilium.io/type annotation support #38260

merged 1 commit into from
Mar 18, 2025

Conversation

brb
Copy link
Member
@brb brb commented Mar 18, 2025

The details of the annotation are described in c18f016 ("k8s: Add "service.cilium.io/type") commit.

@brb brb added release-note/minor This PR changes functionality that users may find relevant to operating Cilium. area/loadbalancing Impacts load-balancing and Kubernetes service implementations labels Mar 18, 2025
@brb brb re 8000 quested a review from joamaki March 18, 2025 09:08
@brb brb marked this pull request as ready for review March 18, 2025 09:08
@brb brb requested review from a team as code owners March 18, 2025 09:08
@brb brb mentioned this pull request Mar 18, 2025
Open
@brb brb force-pushed the pr/brb/exp-lb-svc-type branch 2 times, most recently from cbccc23 to a2a14bd Compare March 18, 2025 09:27
joamaki
joamaki reviewed Mar 18, 2025
View reviewed changes
joamaki
joamaki reviewed Mar 18, 2025
View reviewed changes
joamaki
joamaki reviewed Mar 18, 2025
View reviewed changes
joamaki
joamaki approved these changes Mar 18, 2025
View reviewed changes
Copy link
Contributor
@joamaki joamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nits. Pre-approving.

@brb brb mentioned this pull request Mar 18, 2025
Closed
@brb
exp/lb: Add service.cilium.io/type annotation support
13d1ad7 
The details of the annotation are described in c18f016 ("k8s:
Add "service.cilium.io/type") commit.

Signed-off-by: Martynas Pumputis <martynas@isovalent.com>
@brb brb force-pushed the pr/brb/exp-lb-svc-type branch from a2a14bd to 13d1ad7 Compare March 18, 2025 10:48
@brb
Copy link
Member Author
brb commented Mar 18, 2025

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 18, 2025
@brb brb added this pull request to the merge queue Mar 18, 2025
Merged via the queue into main with commit 7cef766 Mar 18, 2025
287 checks passed
@brb brb deleted the pr/brb/exp-lb-svc-type branch March 18, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joamaki joamaki joamaki approved these changes

Assignees
No one assigned
Labels
area/loadbalancing Impacts load-balancing and Kubernetes service implementations ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brb @joamaki
0