8000 check-encryption-leak:feature: print skb pointer to correlate logs by smagnani96 · Pull Request #38266 · cilium/cilium · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

check-encryption-leak:feature: print skb pointer to correlate logs #38266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 26, 2025
Merged

check-encryption-leak:feature: print skb pointer to correlate logs #38266

merged 1 commit into from
Mar 26, 2025

Conversation

smagnani96
Copy link
Contributor 
Print skb pointer and correlate timestamp for subsequent trace logs in the check-encryption-leak script.

@smagnani96 smagnani96 added kind/enhancement This would improve or streamline existing functionality. area/CI Continuous Integration testing issue or flake area/encryption Impacts encryption support such as IPSec, WireGuard, or kTLS. release-n 8000 ote/ci This PR makes changes to the CI. feature/ipsec Relates to Cilium's IPsec feature feature/wireguard Relates to Cilium's Wireguard feature labels Mar 18, 2025
@smagnani96 smagnani96 changed the base branch from pr/smagnani96/check-encryption-leak-refactor to main March 24, 2025 10:12
@smagnani96
check-encryption-leak:feature: print skb pointer to correlate logs
86d8c21 
This commit adds to the leakage report the $skb pointer, which has
two main advantages:

1. for the bpftrace script itself, now subsequent print reporting the
   type of the packet (ex. "Detected DNS") will use the same timestamp
   and $skb pointer of the previous print. This makes much more easy to
   correlate the output.
2. when using in combination with other packet tracers such as `pwru`,
   while the timestamp might slightly vary, the $skb pointer will point
   to the same packet, simplifying the correlation between the two outputs.

Signed-off-by: Simone Magnani <simone.magnani@isovalent.com>
@smagnani96 smagnani96 force-pushed the pr/smagnani96/check-encryption-leak-print-skb branch from 1496b3d to 86d8c21 Compare March 24, 2025 10:19
@smagnani96
Copy link
Contributor Author

/test

@smagnani96 smagnani96 marked this pull request as ready for review March 24, 2025 15:56
@smagnani96 smagnani96 requested review from a team as code owners March 24, 2025 15:56
@smagnani96 smagnani96 requested a review from pchaigno March 24, 2025 15:56
@pchaigno pchaigno added this pull request to the merge queue Mar 26, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 26, 2025
Merged via the queue into main with commit fe5329c Mar 26, 2025
296 of 297 checks passed
@pchaigno pchaigno deleted the pr/smagnani96/check-encryption-leak-print-skb branch March 26, 2025 14:06
@smagnani96 smagnani96 added backport/author The backport will be carried out by the author of the PR. affects/v1.14 This issue affects v1.14 branch needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch needs-backport/1.17 This PR / issue needs backporting to the v1.17 branch labels Apr 4, 2025
This was referenced Apr 4, 2025
Merged
Merged
Merged
@github-actions github-actions bot added the backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. label Apr 9, 2025
@github-actions github-actions bot added backport-done/1.17 The backport for Cilium 1.17.x for this PR is done. backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. labels Apr 9, 2025
@julianwiedmann julianwiedmann removed needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch needs-backport/1.17 This PR / issue needs backporting to the v1.17 branch labels Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchaigno pchaigno pchaigno approved these changes

Assignees
No one assigned
Labels
affects/v1.14 This issue affects v1.14 branch area/CI Continuous Integration testing issue or flake area/encryption Impacts encryption support such as IPSec, WireGuard, or kTLS. backport/author The backport will be carried out by the author of the PR. backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. backport-done/1.17 The backport for Cilium 1.17.x for this PR is done. feature/ipsec Relates to Cilium's IPsec feature feature/wireguard Relates to Cilium's Wireguard feature kind/enhancement This would improve or streamline existing functionality. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smagnani96 @pchaigno @julianwiedmann
0