bpf/complexity-tests: bpf_xdp coverage improvements #38561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Moving to draft for now, apparently more config options should be enabled in the test, as it still fails in the E2E test while passing ci-verifier: https://github.com/cilium/cilium/actions/runs/14115207803/job/39543635184 |
c6627c9 to
ce252f3
Compare
ce252f3 to
9b9aa5b
Compare
|
/test |
9b9aa5b to
6a7d8d6
Compare
|
/test |
1 similar comment
|
/test |
rgo3
reviewed
Mar 31, 2025
rgo3
approved these changes
Apr 2, 2025
|
Thanks for catching that. I think at some point when working on #29711, I renamed Might be worth to have some sanity check in CI to verify if defines in those complexity tests actually affect anything. |
jschwinger233
approved these changes
Apr 10, 2025
3b3ebec to
6382ddf
Compare
|
/test |
ci-e2e-upgrade test may fail on kernel 5.15 due to verifier complexity limit, while ci-verifier passes in all tests. Increase the coverage of the latter by adding that specific scenario and its extended version. Signed-off-by: Maxim Mikityanskiy <maxim@isovalent.com>
After enabling coverage for EVENTS_MAP_RATE_LIMIT (next commit), clang sometimes uninlines ratelimit_check_and_take (marked as inline, but not __always_inline), which produces this verification error in bpf_host and bpf_lxc on kernel 5.4: Error: program tail_ipv4_to_endpoint: load program: invalid argument: tail_calls are not allowed in programs with bpf-to-bpf calls Mark ratelimit_check_and_take as __always_inline to suppress this behavior. Fixes: 93f1619 ("bpf: Add ratelimiting feature and use it for ICMPv6 responses") Signed-off-by: Maxim Mikityanskiy <maxim@isovalent.com>
The correct define name is EVENTS_MAP_RATE_LIMIT, not EVENTS_MAP_RATE_LIMIT_PER_SECOND. Fix the typo to add coverage for the rate limiting feature. Fixes: b7a26eb ("Add rate limiting on BPF events map") Signed-off-by: Maxim Mikityanskiy <maxim@isovalent.com>
6382ddf to
cc17ebd
Compare
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ci-e2e-upgrade test may fail on kernel 5.15 due to verifier complexity limit, while ci-verifier passes in all tests. Increase the coverage of the latter by adding that specific scenario and its extended version.
Link to that specific occurrence: https://github.com/cilium/cilium/actions/runs/14091707307/job/39498542748?pr=38110
Fix a typo EVENTS_MAP_RATE_LIMIT -> EVENTS_MAP_RATE_LIMIT_PER_SECOND that led to missing coverage for rate limiting on BPF events map (Cc: @siwiutki, #29711).