fix: async FL algorithm to follow FedBuff in aggregation #438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #438 +/- ##
=======================================
Coverage 14.87% 14.87%
=======================================
Files 48 48
Lines 2830 2830
=======================================
Hits 421 421
Misses 2380 2380
Partials 29 29 |
myungjin
reviewed
Jun 21, 2023
| self.weights = self._agg_goal_weights | ||
| # set global weights, by adding scaled aggregated weights with aggregation goal | ||
| self.weights = self.optimizer.scale_add_agg_weights( | ||
| self.weights, self._agg_goal_weights, self._agg_goal |
8000
There was a problem hiding this comment.
Looks like self.weights and self.prev_weights point to the same object.
If so, we need to do a deepcopy here.
Can you please confirm if those two point to different objects?
There was a problem hiding this comment.
Found these are the same; updated the code to deepcopy weights on prev_weights! Thank you very much for nice catch :)
changed the aggregation process to only aggregate delta weights, scale down when agg goal is achieved, and then add the scaled delta weights to the original weights.
162c23a to
6d9883a
Compare
dhruvsgarg
pushed a commit
to dhruvsgarg/flame
that referenced
this pull request
Oct 18, 2024
changed the aggregation process to only aggregate delta weights, scale down when agg goal is achieved, and then add the scaled delta weights to the original weights.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed the aggregation process to only aggregate delta weights, scale down when agg goal is achieved, and then add the scaled delta weights to the original weights.
Description
Please provide a meaningful description of what this change will do, or is for. Bonus points for including links to
related issues, other PRs, or technical references.
Note that by not including a description, you are asking reviewers to do extra work to understand the context of this
change, which may lead to your PR taking much longer to review, or result in it not being reviewed at all.
Type of Change
Checklist