8000 feat: tasklet start time by GustavBaumgart · Pull Request #465 · cisco-open/flame · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: tasklet start time #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 29, 2023
Merged

feat: tasklet start time #465

merged 1 commit into from
Nov 29, 2023

Conversation

GustavBaumgart
Copy link
Collaborator

Description

The metric collector will now also document the start time of tasklets. Along with the runtime of the tasklet, this can be used to produce a diagram that represents the time each tasklet was being executed on a number line.

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@GustavBaumgart
feat: tasklet start time
efd78ff 
The metric collector will now also document the start time of tasklets.
Along with the runtime of the tasklet, this can be used to produce a diagram that represents the time each tasklet was being executed on a number line.
myungjin
myungjin approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor
@myungjin myungjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@myungjin myungjin merged commit ca48d35 into cisco-open:main Nov 29, 2023
dhruvsgarg pushed a commit to dhruvsgarg/flame that referenced this pull request Oct 18, 2024
@GustavBaumgart
feat: tasklet start time (cisco-open#465)
44cc976 
The metric collector will now also document the start time of tasklets.
Along with the runtime of the tasklet, this can be used to produce a diagram that represents the time each tasklet was being executed on a number line.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myungjin myungjin myungjin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GustavBaumgart @myungjin
0