fix: clear metrics and tasklet alias #466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After metrics are reported (usually every round in the save_metrics method) they are cleared. This prevents a metric from being reported more than it should be. Additionally, in order to properly report runtime-related metrics, the alias field was specified on all tasklets.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #466 +/- ##
=======================================
Coverage 14.95% 14.95%
=======================================
Files 49 49
Lines 2735 2735
=======================================
Hits 409 409
Misses 2299 2299
Partials 27 27 ☔ View full report in Codecov by Sentry. |
dhruvsgarg
pushed a commit
to dhruvsgarg/flame
that referenced
this pull request
Oct 18, 2024
After metrics are reported (usually every round in the save_metrics method) they are cleared. This prevents a metric from being reported more than it should be. Additionally, in order to properly report runtime-related metrics, the alias field was specified on all tasklets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After metrics are reported (usually every round in the save_metrics method) they are cleared. This prevents a metric from being reported more than it should be.
Additionally, in order to properly report runtime-related metrics, the alias field was specified on all tasklets.
Type of Change
Checklist