-
Notifications
You must be signed in to change notification settings - Fork 30
Added deployer for default compute #203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #203 +/- ##
=======================================
Coverage 21.35% 21.35%
=======================================
Files 35 35
Lines 1634 1634
=======================================
Hits 349 349
Misses 1275 1275
Partials 10 10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
d25a9d4
to
eddfd47
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left two comments.
72f6cd3
to
8372b86
Compare
Pending rebase with main after PR #204 is merged. That will allow the lint presubmit to succeed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This pr adds a default compute deployer besides the existing custom deployer. The default compute is primarily useful for aggregation tasks and/or running tasks on public datasets which were not correctly mapped to a compute region.
8372b86
to
786784c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This pr adds a default compute deployer besides the existing custom deployer. The default compute is primarily useful for aggregation tasks and/or running tasks on public datasets which were not correctly mapped to a compute region.
This pr adds a default compute deployer besides the existing custom deployer. The default compute is primarily useful for aggregation tasks and/or running tasks on public datasets which were not correctly mapped to a compute region.