8000 Added deployer for default compute by dhruvsgarg · Pull Request #203 · cisco-open/flame · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Added deployer for default compute #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2022

Conversation

dhruvsgarg
Copy link
Contributor

This pr adds a default compute deployer besides the existing custom deployer. The default compute is primarily useful for aggregation tasks and/or running tasks on public datasets which were not correctly mapped to a compute region.

@dhruvsgarg dhruvsgarg requested a review from myungjin August 4, 2022 21:31
@codecov-commenter
8000
Copy link
codecov-commenter commented Aug 4, 2022

Codecov Report

Merging #203 (72f6cd3) into main (65f073b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #203   +/-   ##
=======================================
  Coverage   21.35%   21.35%           
=======================================
  Files          35       35           
  Lines        1634     1634           
=======================================
  Hits          349      349           
  Misses       1275     1275           
  Partials       10       10           
Impacted Files Coverage Δ
pkg/util/helpers.go 7.20% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dhruvsgarg dhruvsgarg force-pushed the add_default_compute branch 2 times, most recently from d25a9d4 to eddfd47 Compare August 4, 2022 22:36
Copy link
Contributor
@myungjin myungjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left two comments.

@dhruvsgarg dhruvsgarg force-pushed the add_default_compute branch 3 times, most recently from 72f6cd3 to 8372b86 Compare August 5, 2022 18:59
@dhruvsgarg
Copy link
Contributor Author

Pending rebase with main after PR #204 is merged. That will allow the lint presubmit to succeed.

myungjin
myungjin previously approved these changes Aug 5, 2022
Copy link
Contributor
@myungjin myungjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

This pr adds a default compute deployer besides the existing custom deployer. The default compute is primarily useful for aggregation tasks and/or running tasks on public datasets which were not correctly mapped to a compute region.
Copy link
Contributor
@myungjin myungjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@myungjin myungjin merged commit 77ea17c into cisco-open:main Aug 5, 2022
@dhruvsgarg dhruvsgarg deleted the add_default_compute branch August 9, 2022 14:23
dhruvsgarg added a commit to dhruvsgarg/flame that referenced this pull request Oct 18, 2024
This pr adds a default compute deployer besides the existing custom deployer. The default compute is primarily useful for aggregation tasks and/or running tasks on public datasets which were not correctly mapped to a compute region.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0