8000 delete design by RaviKhandavilli · Pull Request #254 · cisco-open/flame · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

delete design #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2022
Merged

delete design #254

merged 1 commit into from
Oct 21, 2022

Conversation

RaviKhandavilli
Copy link
Contributor
@RaviKhandavilli RaviKhandavilli commented Oct 19, 2022 •
edited
Loading

Added code to delete design.
Renamed files to maintain consistent naming conventions.

Divlik
Divlik previously approved these changes Oct 20, 2022
View reviewed changes
myungjin
myungjin reviewed Oct 21, 2022
View reviewed changes
Copy link
Contributor
@myungjin myungjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a few comments.

myungjin
myungjin reviewed Oct 21, 2022
View reviewed changes
Copy link
Contributor
@myungjin myungjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments left.

myungjin
myungjin approved these changes Oct 21, 2022
View reviewed changes
Copy link
Contributor
@myungjin myungjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@myungjin myungjin merged commit 2d44ced into cisco-open:main Oct 21, 2022
dhruvsgarg pushed a commit to dhruvsgarg/flame that referenced this pull request Oct 18, 2024
@RaviKhandavilli
delete design (cisco-open#254)
615e677 
Co-authored-by: rakhanda <rakhanda@rakhandas-MBP.attlocal.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myungjin myungjin myungjin approved these changes

@Divlik Divlik Awaiting requested review from Divlik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RaviKhandavilli @myungjin @Divlik
0