new scalajs module #112
new scalajs module #112
Conversation
| @@ -18,7 +19,7 @@ package object parse extends Parser { | |||
| Xor.left(ParsingFailure(error.message, exception)) | |||
| } | |||
|
|
|||
| private[this] def convertJson(j: Any): Json = j match { | |||
| def convertJson(j: Any): Json = j match { | |||
There was a problem hiding this comment.
We need the new module in part so that we can keep the public API of parse consistent across JVM and JS, which means we'll either need to make this private[circe] or to move it to scalajs and switch the direction of the dependency.
There was a problem hiding this comment.
or to move it to scalajs and switch the direction of the dependency.
👍 looks like this is more cleaner way! , i'll update PR accordingly :)
Current coverage is
|
|
Sorry to be out of touch—will finish up review this afternoon. |
|
👍 from me, thanks @chandu0101! Do you mind rebasing? Otherwise I can take care of it this afternoon. |
please do that , otherwise i may end up messing this whole PR :( |
|
_Edit:_ |
|
@chandu0101 Sorry for the delay on this—while looking at it more closely I decided that I wanted to suggest some other changes. I'll aim to open a new PR with your commits rebased and my proposals added today or tomorrow. |
no worries take your own time :) ,looking forward to learn new stuff 👍 |
|
Superseded by #126. |
enable spray-json Scala 2.13.0-M4 build
PR for #93