Make integral number decoding consistent for strings #485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 81.30% (diff: 66.66%)@@ master #485 diff @@
==========================================
Files 80 80
Lines 2193 2199 +6
Methods 2082 2089 +7
Messages 0 0
Branches 111 110 -1
==========================================
+ Hits 1786 1788 +2
- Misses 407 411 +4
Partials 0 0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #476 and provides a kind of workaround for #93. This is a breaking change, but as far as I know nobody is relying on the previous behavior (which is still available by parsing into a
Stringand then usingflatMapor similar).