Fix thread safety of parser #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #114 +/- ##
=======================================
Coverage 96.07% 96.07%
=======================================
Files 4 4
Lines 102 102
Branches 4 5 +1
=======================================
Hits 98 98
Misses 4 4
Continue to review full report at Codecov.
|
|
👍 , thanks for taking care of this! |
|
Sure. Got bitten by this at work, so it would be cool if you could release some time soon-ish! |
|
@ybasket Release is on its way to Maven Central: https://github.com/circe/circe-yaml/releases/tag/v0.13.1 |
|
I was randomly getting a tree node class cast exception on the java HashMap until now. Thanks for this fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should resolve #112. As described in the issue, sharing the
FlatteningConstructorisn't thread-safe as it has unsafeHashMapinside. It's very hard to reproduce as the problematic time window is very small (happens during hash map reorganisation), so relying on my own mental reasoning here for fixing. SnakeYAML explicitly states it isn't thread safe, see https://bitbucket.org/asomov/snakeyaml/wiki/Documentation#markdown-header-threading.Drawback of this PR is that it introduces a little overhead by creating a
FlatteningConstructorfor everyparse, but I think this is justified given the safety gained.