8000 Add tests to `Parser.parseDocuments` by lucaviolanti · Pull Request #342 · circe/circe-yaml · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add tests to Parser.parseDocuments #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Add tests to Parser.parseDocuments #342

wants to merge 5 commits into from

Conversation

lucaviolanti
Copy link
Contributor

Some tests highlight a divergence from Parser.parse which might be undesirable - see comments

@lucaviolanti
Add tests to Parser.parseDocuments
016b213 
Some tests highlight a divergence from `Parser.parse` which might be
undesirable - see comments
@lucaviolanti lucaviolanti marked this pull request as draft November 14, 2022 15:57
@lucaviolanti lucaviolanti mentioned this pull request Nov 14, 2022
Closed
@lucaviolanti lucaviolanti marked this pull request as ready for review November 15, 2022 09:58
@codecov-commenter
Copy link

Codecov Report

Base: 87.35% // Head: 87.35% // No change to project coverage 👍

Coverage data is based on head (0c2cfd8) compared to base (d3d0907).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #342   +/-   ##
=======================================
  Coverage   87.35%   87.35%           
=======================================
  Files          14       14           
  Lines         253      253           
  Branches       18       18           
=======================================
  Hits          221      221           
  Misses         32       32

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

8000
@sideeffffect
Copy link
Collaborator

Could you turn those tests red so that it's obvious what fails?
Than we can work on finding ways to make them green.

@sideeffffect sideeffffect mentioned this pull request Nov 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucaviolanti @codecov-commenter @sideeffffect
0