Adapt columnar stripe metadata updates for PostgreSQL 18 #8030
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## m3hm3t/pg18_support #8030 +/- ##
=======================================================
+ Coverage 89.11% 89.12% +0.01%
=======================================================
Files 284 284
Lines 61595 61600 +5
Branches 7707 7707
=======================================================
+ Hits 54890 54902 +12
+ Misses 4477 4469 -8
- Partials 2228 2229 +1 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR adapts columnar stripe metadata updates for PostgreSQL 18 by switching from the deprecated in‐place update (heap_inplace_update) to CatalogTupleUpdate and adjusting the lock level accordingly.
- Switch to CatalogTupleUpdate for PG 18+
- Introduce a conditional lock mode (RowExclusiveLock vs AccessShareLock) based on the PostgreSQL version
- Remove the PG <18 only in-place update block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8019
Background / Problem
heap_inplace_update()and related helpers.UpdateStripeMetadataRow()to patch thecolumnar_stripecatalog row with the stripe file-offset, size, and row-count.file_offset = 0, causing every insert to abort withERROR: attempted columnar write … to invalid logical offset: 0Scope of This PR
heap_inplace_update()unchanged).CatalogTupleUpdate()on PG 18+, matching core’s new catalog-update API.AccessShareLock→RowExclusiveLockwhen the normal heap-update path is taken.