cv api4 - Add support for more where operators
#184
Conversation
|
Test was passing, except for some odd failures in 5.51,wp-demo,min. Probably unrelated, but will fire one more run. |
|
civibot, test this please |
758093b to
bfcdcea
Compare
|
@totten the full list of accepted operators can be obtained by calling |
|
Thanks, good point @colemanw. Updated to prefer a live list. |
| })); | ||
| } | ||
| else { | ||
| $this->operators = '\<=|\>=|=|!=|\<|\>|IS NULL|IS NOT NULL|IS EMPTY|IS NOT EMPTY|LIKE|NOT LIKE|IN|NOT IN|CONTAINS|NOT CONTAINS|REGEXP|NOT REGEXP|REGEXP BINARY|NOT REGEXP BINARY'; |
There was a problem hiding this comment.
I mean, if you really wanna support < 5.30, then this list is a bit long. Those weren't all available at the time.
There was a problem hiding this comment.
Well... shrug. I just don't want the parser to crash where it was non-crashing before.
As to which operators work on which exact versions -- that's not really the concern of cv. The goal is to pass-through data to civicrm_api4() -- then civicrm_api4() can figure out whether it likes the request. (Same as with entity-names and action-names.) (The parser just has to be good enough to send in well-formed requests.)
Before:
The
whereshorthand (+w) supports some operators, likeLIKE:cv api4 Entity.get -T +w 'name LIKE Opti%' +s nameAfter:
The
whereshorthand (+w) supports more operators, likeCONTAINSorREGEXP: