8000 Trimmed down version of #211 - just remove the `@` suppression by demeritcowboy · Pull Request #212 · civicrm/cv · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Trimmed down version of #211 - just remove the @ suppression #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 10, 2024
Merged

Trimmed down version of #211 - just remove the @ suppression #212

merged 1 commit into from
Sep 10, 2024

Conversation

demeritcowboy
Copy link
Contributor
@demeritcowboy demeritcowboy commented Sep 6, 2024 •
edited
Loading

This can lead to silent fatals where cv just appears to do nothing, and doesn't seem needed.

One way to reproduce is:

  1. Install drupal 10+civi (with php 8.1+ since you can't with anything lower anyway).
  2. Using php 7.4, run something like cv vars:show. It just exits. Running with -vvv doesn't tell you the actual problem.
  3. If you remove the @, then it tells you there's a symfony lib that isn't compatible with php 7. Also there's a message about composer.

@demeritcowboy demeritcowboy mentioned this pull request Sep 6, 2024
Closed
@totten
Copy link
Member
totten commented Sep 10, 2024

Sounds good to me.

@totten totten merged commit c505f7c into civicrm:master Sep 10, 2024
1 check passed
@demeritcowboy demeritcowboy deleted the err2 branch September 10, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@demeritcowboy @totten
0