Kotlin serialization: Numbers #364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With Jackson we can use Java's BigDecimal but since because this is not serializable with Kotlin Serialization we use Double instead.
|
I vote for @contextual and letting the users define their own serializer Not a fan of the pending blog post about a fabrikt being the root cause of a some international banking incident due to loss of precision. |
Same here 😬 I'd rather see some positive blog posts 😌 I've updated the PR to add |
|
LGTM - Sorry for the delay |
cjbooms
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Jackson we use Java's BigDecimal for numbers without a format keyword, but because Java types are not serializable with Kotlin Serialization we need to use a Kotlin native type instead.
I believe the best we can do is Double although it has lower precision than BigDecimal.Alternatively we could allow the user to provide his own custom serializer for BigDecimal (and other Java types like UUID and URI) as discussed in this issue by annotating the field with
@Contexual.Update:
In order to not loose precision we annotate the field with
@Contexualand leave it to the user to provide a custom serializer. This is aligns with the recommended approach in the documentation.We can add the same possibility for string formats (
uuid,uri,base64,binary), but because no precision is lost we could add it as a configuration option. I prefer to do that in a future PR.