fix(html5_video): avoid memory leak in getDuration call #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leandromoreira
approved these changes
Oct 7, 2021
|
thanks @bikegriffith thoughts @jhonatangomes @towerz @joaopaulovieira ? |
|
LGTM |
towerz
approved these changes
Oct 8, 2021
There was a problem hiding this comment.
@jhonatangomes Everything looks good. I think you can just run some checks to see if there's any side effect or any dependency that could be affected by this before merging.
|
Thanks for the quick review! I've done quite a bit of testing on my own in various scenarios and I can't see any side effects. Would love to see this in an official release as soon as reasonably possible (because the new multi-repo setup for Clappr makes it a little tricky to get this fix into a build downstream from my fork, and it's happening to quite a lot of iOS users) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes clappr/clappr#2035 by more carefully managing the call to
_updateSettingswhenel.seekablefails for a live broadcast. This can happen in iOS Safari (specifically for live broadcast with no sliding dvr window) and results in a memory leak and crash within a few seconds-minutes.Changes
How to test
Test in iOS Safari for a live broadcast. I was able to verify locally very easily.
A picture/video tells a thousand words
Before this PR
Original memory profile showed leak:
After this PR
New memory profile looks clean!