8000 Add Chinese language. by ahu · Pull Request #90 · clappr/clappr-core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add Chinese language. #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2022
Merged

Add Chinese language. #90

merged 1 commit into from
Nov 25, 2022

Conversation

ahu
Copy link
Contributor
@ahu ahu commented Nov 22, 2022 •
edited
Loading

Summary

Just add Chinese language as shown above.

Changes

Only in file /src/plugins/strings/strings.js, which
from line 119 to 126 add these:

'zh': {
        'live': '直播',
        'back_to_live': '返回直播',
        'disabled': '已禁用',
        'playback_not_supported': '您的浏览器不支持该视频的播放。请尝试使用另一个浏览器。',
        'default_error_title': '无法播放视频。',
        'default_error_message': '在尝试加载视频时出现了问题。',
},

and line 140:

this._messages['zh-CN'] = this._messages['zh']

How to test

  1. config the language to zh-CN.
  2. you'll see the Chinese UI.

Images

Before this PR

WX20221125-092907.png

After this PR

WX20221125-092822.png

@leaofelipe
Copy link
Member

Hi @ahu! Thank you for your contribution!
Can you fill the Pull Request template correctly?

@ahu
Copy link
Contributor Author
ahu commented Nov 25, 2022

Hi @ahu! Thank you for your contribution! Can you fill the Pull Request template correctly?

@leaofelipe Ok, I refill it.

@leaofelipe
Copy link
Member

@ahu! Thank you! 👏🏻👏🏻👏🏻

@leaofelipe leaofelipe self-assigned this Nov 25, 2022
@leaofelipe leaofelipe added the improvement A piece of code that does not change an existing feature. (e.g.: test addition) label Nov 25, 2022
@pedrochamberlain pedrochamberlain merged commit cf84529 into clappr:master Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leaofelipe leaofelipe leaofelipe approved these changes

@pedrochamberlain pedrochamberlain pedrochamberlain approved these changes

@felipecesr felipecesr Awaiting requested review from felipecesr

@jhonatangcavalcanti jhonatangcavalcanti Awaiting requested review from jhonatangcavalcanti

@paulocesarjr paulocesarjr Awaiting requested review from paulocesarjr

Assignees

@leaofelipe leaofelipe

Labels
improvement A piece of code that does not change an existing feature. (e.g.: test addition)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahu @leaofelipe @pedrochamberlain
0