8000 Update near-duplicate sets by elisno · Pull Request #781 · cleanlab/cleanlab · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update near-duplicate sets #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 26, 2023
Merged

Update near-duplicate sets #781

merged 4 commits into from
Jul 26, 2023

Conversation

elisno
Copy link
Member
@elisno elisno commented Jul 25, 2023

After this PR:

  • Examples that are not flagged with is_near_duplicate_issue = True will have an empty near-duplicate set.
  • The near-duplicates are now symmetric.

@elisno elisno requested a review from jwmueller July 25, 2023 16:02
@codecov
Copy link
codecov bot commented Jul 25, 2023 •
edited
Loading

Codecov Report

Merging #781 (d61e922) into master (63254c5) will increase coverage by 0.15%.
Report is 4 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #781      +/-   ##
==========================================
+ Coverage   96.44%   96.60%   +0.15%     
==========================================
  Files          60       63       +3     
  Lines        4726     4826     +100     
  Branches      823      838      +15     
==========================================
+ Hits         4558     4662     +104     
+ Misses         87       84       -3     
+ Partials       81       80       -1
Files Changed Coverage Δ
cleanlab/datalab/issue_manager/duplicate.py 96.70% <100.00%> (+0.15%) ⬆️

... and 11 files with indirect coverage changes

jwmueller
jwmueller reviewed Jul 26, 2023
View reviewed changes
jwmueller
jwmueller reviewed Jul 26, 2023
View reviewed changes
jwmueller
jwmueller approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member
@jwmueller jwmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that black format is not passing in CI, so update that first.

Otherwise LGTM, feel free to merge once you confirm the questions I had!

@elisno elisno merged commit cc0fb47 into cleanlab:master Jul 26, 2023
ulya-tkch added a commit to ulya-tkch/cleanlab that referenced this pull request Jul 26, 2023
@ulya-tkch
Revert "Update near-duplicate sets (cleanlab#781)"
d8dbf80 
This reverts commit cc0fb47.
ulya-tkch pushed a commit to ulya-tkch/cleanlab that referenced this pull request Jul 26, 2023
@elisno @ulya-tkch
Update near-duplicate sets (cleanlab#781)
e7cffba
@huiwengoh huiwengoh mentioned this pull request Jul 27, 2023
Merged
ulya-tkch added a commit to ulya-tkch/cleanlab that referenced this pull request Aug 23, 2023
@ulya-tkch
Revert "Update near-duplicate sets (cleanlab#781)"
d8b69f8 
This reverts commit cc0fb47.
ulya-tkch pushed a commit to ulya-tkch/cleanlab that referenced this pull request Aug 23, 2023
@elisno @ulya-tkch
Update near-duplicate sets (cleanlab#781)
d5c3fd7
@elisno elisno mentioned this pull request Nov 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwmueller jwmueller jwmueller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elisno @jwmueller
0