8000 Consume dependabot minor versions for go modules by williammartin · Pull Request #11213 · cli/cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Consume dependabot minor versions for go modules #11213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2025

Conversation

williammartin
Copy link
Member

Description

Fixes https://github.com/github/cli/issues/933

Reviewer Notes

i decided to do the simplest thing here and just start accepting minor version upgrades with no concern for grouping or cooldowns. I believe it makes more sense to do the baseline and adjust with data.

@Copilot Copilot AI review requested due to automatic review settings July 3, 2025 10:16
@williammartin williammartin requested a review from a team as a code owner July 3, 2025 10:16
@williammartin williammartin requested a review from babakks July 3, 2025 10:16
@williammartin williammartin linked an issue Jul 3, 2025 that may be closed by this pull request
Copy link
Contributor
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Dependabot configuration for Go modules to start accepting minor version upgrades by removing the ignore rule for semver-minor updates.

  • Removed the semver-minor ignore entry under Go modules
  • Continued allowing major version updates to be ignored as before
Comments suppressed due to low confidence (1)

.github/dependabot.yml:10

  • Align the indentation of the version-update:semver-major entry under update-types so it matches the YAML list indentation for clarity and consistency.
        - version-update:semver-major

Copy link
Member
@babakks babakks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🙏

Do you want to try the cool-down configuration in this PR? We can only enable it for minor updates (like a week or so).

@williammartin
Copy link
Member Author

No, I think I explained why in the PR description? Let me know if you disagree.

@babakks
Copy link
Member
babakks commented Jul 3, 2025

No, I think I explained why in the PR description? Let me know if you disagree.

Sorry, I missed that. Ship it. 🚀

@williammartin
Copy link
Member Author

I too, often go straight to files changed and then realise I missed important context 🙈

@williammartin williammartin merged commit 5450b7f into trunk Jul 3, 2025
18 checks passed
@williammartin williammartin deleted the 11207-consume-dependabot-minor-upgrades branch July 3, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consume dependabot minor upgrades
2 participants
0