Inject token into bump-go workflow #11233
Merged
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR injects the GitHub token into the bump-go workflow to enable authenticated operations when bumping Go module files.
- Adds the
GH_TOKENenvironment variable sourced fromsecrets.GITHUB_TOKEN - Ensures the
bump-go.shscript can push changes back to the repository
| @@ -18,5 +18,6 @@ jobs: | |||
| GIT_AUTHOR_NAME: cli automation | |||
| GIT_COMMITTER_EMAIL: noreply@github.com | |||
| GIT_AUTHOR_EMAIL: noreply@github.com | |||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | |||
There was a problem hiding this comment.
Consider adding an explicit permissions block at the top of the workflow (e.g., permissions: contents: write) to limit the scope of GITHUB_TOKEN and follow the principle of least privilege.
Copilot uses AI. Check for mistakes.
This is because go mod tidy seems to add minor version to the go mod directive when it is missing.
|
I'm merging this without review because I perceive it as low risk and I'd really like to see it run on the daily schedule with these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descripion
Fixes https://github.com/cli/cli/actions/runs/16084039946/job/45392776335