8000 Add setup-go to bump-go workflow by williammartin · Pull Request #11237 · cli/cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add setup-go to bump-go workflow #11237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2025
Merged

Conversation

williammartin
Copy link
Member

Description

Hopefully fixes https://github.com/cli/cli/actions/runs/16094838218/job/45417833155

Ideally, this will ensure that we have an up to date version when we run go mod tidy.

Ideally, this will ensure that we have an up to date version when we run
go mod tidy.
@Copilot Copilot AI review requested due to automatic review settings July 6, 2025 05:05
@williammartin williammartin requested a review from a team as a code owner July 6, 2025 05:05
@williammartin williammartin requested a review from andyfeller July 6, 2025 05:05
@williammartin williammartin removed the request for review from andyfeller July 6, 2025 05:05
Copy link
Contributor
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR ensures the workflow installs the Go version specified in go.mod before running the bump step.

  • Adds a setup-go action to install Go from go.mod
  • Places the setup step before the bump/version workflow
Comments suppressed due to low confidence (1)

.github/workflows/bump-go.yml:16

  • [nitpick] Consider adding check-latest: true under with: to always fetch the newest patch version of Go, ensuring the workflow uses the most up-to-date release when running go mod tidy.
        uses: actions/setup-go@v5

@williammartin
Copy link
Member Author

Merging this without waiting for review because I perceive it as low risk and want to see the result on the scheduled run tonight.

@williammartin williammartin merged commit df5e6d9 into trunk Jul 6, 2025
17 checks passed
@williammartin williammartin deleted the wm/add-setup-go-to-bump-go branch July 6, 2025 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0