8000 Avoid checking for new releases when authenticating git by mislav · Pull Request #3083 · cli/cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Avoid checking for new releases when authenticating git #3083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2021
Merged

Avoid checking for new releases when authenticating git #3083

merged 1 commit into from
Mar 4, 2021

Conversation

mislav
Copy link
Contributor
@mislav mislav commented Mar 4, 2021

In general, avoid displaying upgrade notice if any output is redirected, not just stderr. This also alleviates the need to specifically check for gh completion -s <shell>, gh __complete, and other scripting scenarios where we absolutely don't want to trigger any upgrade checks or notices.

Fixes #3080

@mislav
Avoid checking for new releases when authenticating git
c63247f 
Avoid displaying upgrade notice if any output is redirected. This also
alleviates the need to specifically check for `gh completion -s
<shell>`, `gh __complete`, and other scripting scenarios where we
absolutely don't want to trigger any upgrade checks or notices.
@mislav mislav requested a review from a team March 4, 2021 16:42
@mislav mislav merged commit 6b483aa into trunk Mar 4, 2021
@mislav mislav deleted the update-notice-redirect branch March 4, 2021 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vilmibm vilmibm vilmibm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLI release message pops up during git push
2 participants
@mislav @vilmibm
0