gh run rerun #3333
gh run rerun #3333
Conversation
| @@ -150,6 +150,25 @@ type RunsPayload struct { | |||
| WorkflowRuns []Run `json:"workflow_runs"` | |||
| } | |||
|
|
|||
| func GetRunsWithFilter(client *api.Client, repo ghrepo.Interface, limit int, f func(Run) bool) ([]Run, error) { | |||
There was a problem hiding this comment.
Nit: couldn't the caller just do the filtering on the result of GetRuns instead of having to inject a filter func?
There was a problem hiding this comment.
i have to filter in this way for another upcoming command and it seemed like a reasonable time to DRY but I do not have strong feelings either way
| if len(runs) == 0 { | ||
| return errors.New("no recent runs have failed; please specify a specific run ID") | ||
| } | ||
| runID, err = shared.PromptForRun(cs, runs) |
There was a problem hiding this comment.
Not new in this PR, but: I still don't think that it's safe to use ANSI color sequences in Survey prompt options. #2923 (comment)
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
oh this is already done. where are you seeing ANSI color codes going into survey?
PromptForRun does not use any color.
pkg/cmd/run/rerun/rerun.go
Outdated
| Use: "rerun [<run-id>]", | ||
| Short: "Rerun a given run", | ||
| Args: cobra.MaximumNArgs(1), | ||
| Hidden: true, |
There was a problem hiding this comment.
Do we need to explicitly hide subcommands if the parent command is already hidden?
There was a problem hiding this comment.
i don't think so, it was just a reflex.
This PR implements
gh run rerun, a simple wrapper around theactions/runs/<run-id>/rerunAPI endpoint.This PR also adds
GetRunsWithFilterwhich I intend to use ingh run watch.