8000 FreshDesk.ListTickets (patch) by petrolivka · Pull Request #599 · clientIO/appmixer-connectors · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

FreshDesk.ListTickets (patch) #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2025
Merged

FreshDesk.ListTickets (patch) #599

merged 1 commit into from
Jun 27, 2025

Conversation

petrolivka
Copy link
Contributor
@petrolivka petrolivka commented Jun 26, 2025 •
edited by coderabbitai bot
Loading

Fix for ListTicket component where introduced updated_since param and set to very early date to make sure all issues (including those older than 30 days) will be captured.

Screenshot 2025-06-26 at 11 47 43

Summary by CodeRabbit

  • Bug Fixes
    • Resolved an issue where the ticket listing feature only returned 30 tickets; it now retrieves a more complete list of tickets.

@petrolivka
Introduced updated_since according to doc for /tickets endpoint. Move…
9cf24fb 
…d the updated_since to very early date to make sure all the issues can be captured.
@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented Jun 26, 2025 •
edited
Loading

Walkthrough

The changes update the Freshdesk integration by incrementing the bundle version and updating the changelog to document a fix in the ListTickets component. The fix involves adding an updated_since parameter to API requests, allowing retrieval of more than 30 tickets.

Changes

Files/Paths Change Summary
src/appmixer/freshdesk/bundle.json Incremented version to 1.1.2 and updated changelog to document the ListTickets fix.
src/appmixer/freshdesk/tickets/ListTickets/ListTickets.js Added updated_since query parameter (set to 30 years ago) to ticket list API requests.

Suggested reviewers

  • jirihofman

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

npm error Exit handler never called!
npm error This is an error with npm itself. Please report this error at:
npm error https://github.com/npm/cli/issues
npm error A complete log of this run can be found in: /.npm/_logs/2025-06-26T09_50_55_576Z-debug-0.log

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between aa7fbfc and 9cf24fb.

📒 Files selected for processing (2)
  • src/appmixer/freshdesk/bundle.json (2 hunks)
  • src/appmixer/freshdesk/tickets/ListTickets/ListTickets.js (1 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
`src/appmixer/**/*.js`: Not necessary to add try/catch blocks in their `receive`...

src/appmixer/**/*.js: Not necessary to add try/catch blocks in their receive function. Appmixer engine automatically handles any exceptions that originate in these async functions.

The directive "use strict"; is desirable here

⚙️ Source: CodeRabbit Configuration File

List of files the instruction was applied to:

  • src/appmixer/freshdesk/tickets/ListTickets/ListTickets.js
`src/appmixer/**/bundle.json`: The bundle.json file must follow the specified sc...

src/appmixer/**/bundle.json: The bundle.json file must follow the specified schema, including name (lower case, appmixer.${CONNECTOR_NAME}), version (default 1.0.0), and changelog (object describing changes).

📄 Source: CodeRabbit Inference Engine (.github/copilot-instructions.md)

List of files the instruction was applied to:

  • src/appmixer/freshdesk/bundle.json
`**/*/bundle.json`: Make sure `version` also matches the last entry in `changelog`

**/*/bundle.json: Make sure version also matches the last entry in changelog

⚙️ Source: CodeRabbit Configuration File

List of files the instruction was applied to:

  • src/appmixer/freshdesk/bundle.json
🔇 Additional comments (3)
src/appmixer/freshdesk/bundle.json (2)

3-3: Version increment looks good.

The version bump from 1.1.1 to 1.1.2 correctly follows semantic versioning for a patch fix.

21-23: Changelog entry accurately documents the fix.

The changelog entry clearly describes the issue being resolved and aligns with the actual code changes made to the ListTickets component.

src/appmixer/freshdesk/tickets/ListTickets/ListTickets.js (1)

86-86: Effective fix for the 30-ticket limitation.

The addition of the updated_since parameter with a date 30 years in the past ensures comprehensive ticket retrieval. The implementation correctly:

  • Uses moment.js for reliable date calculation
  • Applies the YYYY-MM-DD format expected by the Freshdesk API
  • Scopes the fix to non-filtered requests where the issue occurs

This approach effectively addresses the reported limitation while maintaining the existing filtering logic.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai auto-generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@vtalas vtalas merged commit 214e50c into clientIO:dev Jun 27, 2025
2 checks passed
@vtalas vtalas changed the title FreshDesk ListTickets FreshDesk.ListTickets (patch) Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtalas vtalas vtalas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petrolivka @vtalas
0