Respect insecure-skip-tls-verify on kubeconfig
#103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Diogo Silva <Selvaticus@users.noreply.github.com>
93839ca to
0476e85
Compare
|
@Selvaticus the CI seems to be failing. Also can we name the Config flag the same as kubeconfig but snake case? |
Signed-off-by: Diogo Silva <Selvaticus@users.noreply.github.com>
|
This probably should also be a parameter to the If it allows for a |
|
I agree |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found.
|
Signed-off-by: Sambhav Kothari <sambhavs.email@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description of PR
Currently,
cloudcoilexpect certificate data to be present on the kubeconfig and respects it. The problem is not always will users have that, although not best practice sometimes users will just want to skip the api-server certificate verification.This is done through setting
insecure-skip-tls-verify: Trueon the cluster data section.Currently,
cloudcoildoes not check for such option and will carry on with the information available which means using the defaultSSLContextand using whatever CAs are available in the machine. If the machine is not set up to be able to verify the api-server certificate the connection will fail with an SSL error.This PR adds a check for the value of
insecure-skip-tls-verifyand ifTrueit will skip setting aSSLContextand will sethttpx.Clientto not check the server certificate