Fix config parsing when using cert authentication with skip_verify #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…True When skip_verify is True, method `load_cert_chain` still needs to be called. Alternatively, just keep the previous SSLContext object. Signed-off-by: univ <11343398+mayu2010 8000 @users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found.
|
sambhav
approved these changes
Feb 17, 2025
|
Released as part of v0.5.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds/changes/fixes a BUG of APIClient：when skip_verify in KUBECONFIG is True, SSLContext is replaced but certfile & keyfile are not loaded, causing 401 Error.
When skip_verify is True, method
load_cert_chainstill needs to be called. Alternatively, just keep the previous SSLContext object.