8000 Fix responsiveness of css by osterman · Pull Request #543 · cloudposse/atmos · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix responsiveness of css #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 24, 2024
Merged

Fix responsiveness of css #543

merged 3 commits into from
Feb 24, 2024

Conversation

osterman
Copy link
Member
@osterman osterman commented Feb 23, 2024 •
edited
Loading

what

  • Use % instead of vw, since the outter container is capped at a certain px size.
  • Set a minimum height of the header in px, otherwise if based on vh it can be impossibly small and gets eaten by the nav bar
  • Move the footer outside of main, so it's consistent with the header.

why

@osterman osterman requested review from a team as code owners February 23, 2024 22:47
@osterman osterman requested review from hans-d and gberenice February 23, 2024 22:47
@aknysh aknysh added the patch A minor, backward compatible change label Feb 24, 2024
@osterman osterman merged commit 5715d93 into master Feb 24, 2024
@osterman osterman deleted the fix-css branch February 24, 2024 04:33
@nitrocode
Copy link
Member

Should website or github action changes trigger a release? I always figured these changes would get a no-release label since there arent any changes to atmos cli.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh approved these changes

@hans-d hans-d Awaiting requested review from hans-d hans-d was automatically assigned from cloudposse/contributors

@gberenice gberenice Awaiting requested review from gberenice gberenice was automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
patch A minor, backward compatible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@osterman @nitrocode @aknysh
0