8000 Update `atmos` "deps" calculation. Update docs. by aknysh · Pull Request #256 · cloudposse/atmos · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update atmos "deps" calculation. Update docs. #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
Nov 21, 2022
Merged

Update atmos "deps" calculation. Update docs. #256

merged 27 commits into from
Nov 21, 2022

Conversation

aknysh
Copy link
Member
@aknysh aknysh commented Nov 18, 2022 •
edited
Loading

what && why

  • Update atmos "deps" calculation. In some cases, when more than one different YAML stack config files imported the same import (b/c some components in both derived from the same base component), then all of those stack config files were added to the component's "deps" list (resulting in Spacelift stacks having unrelated dependency labels which would cause unnecessary stack triggering). This PR fixes that issue
  • Document atmos completion CLI command
  • Add "Component-Oriented Programming" page to document Component-Oriented Programming supported by atmos
  • Update "Component Inheritance" page to remote "Component-Oriented Programming" description and just link to the new page https://pr-256.atmos-docs.ue2.dev.plat.cloudposse.org/core-concepts/components/inheritance/
  • Add "Example GitHub Action" section to "Atlantis Integration" page (https://pr-256.atmos-docs.ue2.dev.plat.cloudposse.org/integrations/atlantis/#example-github-action) . A lot of thanks to @jamengual for sharing it
  • Some other improvements and typo fixes

@aknysh aknysh added the minor New features that do not break anything label Nov 18, 2022
@aknysh aknysh requested review from a team as code owners November 18, 2022 23:17
@aknysh aknysh self-assigned this Nov 18, 2022
@aknysh aknysh requested a review from Gowiem November 18, 2022 23:17
@aknysh aknysh requested a review from nitrocode November 18, 2022 23:45
nitrocode
nitrocode previously approved these changes Nov 18, 2022
View reviewed changes
Copy link
Member
@nitrocode nitrocode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. A couple nitpicks

@aknysh @nitrocode
Update website/docs/core-concepts/components/components.md
e561dff 
Co-authored-by: nitrocode <7775707+nitrocode@users.noreply.github.com>
@aknysh aknysh temporarily deployed to preview November 18, 2022 23:59 Inactive
@aknysh @nitrocode
Update website/docs/core-concepts/components/components.md
e3f5a30 
Co-authored-by: nitrocode <7775707+nitrocode@users.noreply.github.com>
@aknysh aknysh temporarily deployed to preview November 19, 2022 00:00 Inactive
@aknysh @nitrocode
Update website/docs/core-concepts/components/describe-components.md
94fc89b 
Co-authored-by: nitrocode <7775707+nitrocode@users.noreply.github.com>
@aknysh aknysh temporarily deployed to preview November 19, 2022 00:00 Inactive
@aknysh @nitrocode
Update website/docs/core-concepts/components/describe-components.md
929393c 
Co-authored-by: nitrocode <7775707+nitrocode@users.noreply.github.com>
@aknysh aknysh temporarily deployed to preview November 19, 2022 00:01 Inactive
@aknysh aknysh temporarily deployed to preview November 19, 2022 00:11 Inactive
@aknysh aknysh requested a review from nitrocode November 19, 2022 00:15
@aknysh aknysh merged commit 3a5eafe into master Nov 21, 2022
@aknysh aknysh deleted the update-website-4 branch November 21, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osterman osterman osterman approved these changes

@nitrocode nitrocode nitrocode approved these changes

@goruha goruha Awaiting requested review from goruha

@mcalhoun mcalhoun Awaiting requested review from mcalhoun

@Nuru Nuru Awaiting requested review from Nuru

@Gowiem Gowiem Awaiting requested review from Gowiem Gowiem was automatically assigned from cloudposse/contributors

@korenyoni korenyoni Awaiting requested review from korenyoni korenyoni was automatically assigned from cloudposse/contributors

@jamengual jamengual Awaiting requested review from jamengual

Assignees

@aknysh aknysh

Labels
minor New features that do not break anything
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aknysh @osterman @nitrocode
0