8000 [probes.external] Merge config and server proto by manugarg · Pull Request #956 · cloudprober/cloudprober · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[probes.external] Merge config and server proto #956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2025
Merged

[probes.external] Merge config and server proto #956

merged 1 commit into from
Jan 7, 2025
+293 −373

Conversation

manugarg
Copy link
Contributor
@manugarg manugarg commented Jan 3, 2025 •
edited
Loading

This makes glaze work for cloudprober, see #947

There are various side effect of this change:

  • Currently Probe{Request,Reply} messages are in cloudprober protobuf package but with this move they will be in cloudprober.probes.external package. However even with this change, existing clients should continue to work with the new version of cloudprober as package name is not part of the wire format. I verified that using the example included in cloudprober.
  • Code generated for Go will continue to work as it is as it will be in the same Go package as earlier.
  • For users generating code for their language, they will have to update the code generating scripts/tools to use the merged file (optionally splitting messages - see the proto file for how it works, we are using it for python).
  • Other language specific changes:
    • C++ puts all code in the same namespace as proto package. If you've a C++ client you'll need to update it use cloudprober::probes::external namespace instead of cloudprober namespace.
    • For python, there are no changes in the client. Also, we provide a pypi package for python: https://pypi.org/project/cloudprober-serverutils/

@manugarg manugarg mentioned this pull request Jan 7, 2025
Closed
@manugarg manugarg merged commit dc46239 into main Jan 7, 2025
14 checks passed
@manugarg manugarg added this to the v0.13.9 milestone Jan 7, 2025
@antholeole
Copy link

Nice - thank you!

By internal repo, we use git on borg, not g3. Not sure if there's a copy of this in G3, have not checked.

@manugarg
Copy link
Contributor Author
manugarg commented Jan 7, 2025

Nice - thank you!

By internal repo, we use git on borg, not g3.

I see.

Not sure if there's a copy of this in G3, have not checked.

yeah, there is one in third_party.

@manugarg manugarg deleted the external_proto_merge branch January 7, 2025 20:05
@BrewTestBot BrewTestBot mentioned this pull request Jan 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.13.9
Development

Successfully merging this pull request may close these issues.
2 participants
@manugarg @antholeole
0