feat: fileshare custom password support #2493
Conversation
|
|
|
Thanks for the PR! The overall UX is a bit confusing. Imagine yourself as a new user: I set password for my share link, but there's nowhere I can input my password while accessing the share link, I can access it without password. I haven't come up with a good way to accommodate this yet. A possible UI workaround is: In the dialog showing final share link, add a checkbox |
|
I got your point here. Password check, custom password set display, and final password display now like this: 20250615-201047.mp4 |
|
btw I'm not sure is it a bug here: changing final share link display also causes diffs between browser display and what the "Send the link" button sends to Which means while we do not directly show url carrying password, "Send the link" button still sends that url without much description. But what really confused me is that actually we have some very likely share link descrption content in i18n asset here application.json#L467? However they are never referenced https://github.com/search?q=repo%3Acloudreve%2Ffrontend%20shareLinkShareContent&type=code. |
This i18n phrase is inherited from v3, which is not used anymore, you can remove it. |
| @@ -20,6 +20,7 @@ type ( | |||
| ShareCreateService struct { | |||
| Uri string `json:"uri" binding:"required"` | |||
| IsPrivate bool `json:"is_private"` | |||
| Password string `json:"password" binding:"max=32,alphanum,omitempty"` | |||
There was a problem hiding this comment.
nit: run go fmt before committing changes
|
Thanks |
#2432. frontend pr: cloudreve/frontend#259
password rules, and frontend styles may need further discussion.
20250615-201047.mp4